D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

This revision was automatically updated to reflect the committed changes. Closed by commit R116:bc4d82c15657: plasma-nm Connection Icon not showing correct icon when using a bridge (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phab

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas added a comment. Hey Jan, please make this commit on my behalf as I don't have commit access right now and I'm not planning to apply for it any time soon. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18689 To: rthomas, jgrulich, #

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 51009. rthomas added a comment. I've also moved isConnectionTypeVirtual() in uiutils.cpp. Forgot to do that! REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689?vs=51006&id=51009 REVISION DETA

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 51006. rthomas added a comment. Moved isConnectionTypeVirtual() below isConnectionTypeSupported() REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689?vs=50900&id=51006 REVISION DETAIL https:

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > uiutils.h:126 > + */ > +static bool > isConnectionTypeVirtual(NetworkManager::ConnectionSettings::ConnectionType > type); > + Can you just move this metho

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 50900. rthomas added a comment. Shouldn't have removed the existing condition to check if the connection object is not valid. Added it back. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 50899. rthomas added a comment. Hey Jan, I've made the changes you suggested. Let me know if anything needs to be fixed. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689?vs=50771&id=50

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

jgrulich added a comment. That sounds like a bug in NetworkManager, because ActivatingConnection should be the one which will become PrimaryConnection, that's what the documentation says, that's the reason why we use it. If it's a NM bug, we still need a workaround. In your code, you ca

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas added a comment. In D18689#404502 , @jgrulich wrote: > This doesn't seem to be a correct fix. We should be using icon for whatever connection is primary, not only when primary connection is wifi / ethernet / modem / bluetooth. If you che

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas added a comment. In D18689#404506 , @jgrulich wrote: > Correct fix would be to set icon for bridge connections in the last else branch at the end of setIcons() method, probably guarded with a condition whether the user has enabled virtua

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

jgrulich added a comment. Correct fix would be to set icon for bridge connections in the last else branch at the end of setIcons() method, probably guarded with a condition whether the user has enabled virtual connections. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

jgrulich added a comment. This doesn't seem to be a correct fix. We should be using icon for whatever connection is primary, not only when primary connection is wifi / ethernet / modem / bluetooth. If you check NM on dbus, what is the primary connection there? Is it the bridge one? REPOSITO

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 50771. rthomas added a reviewer: Plasma. rthomas added a comment. Should have used '&&' in the if statement instead of '||'. We want to shift to the PrimaryConnection if the Device is not among Wifi, Ethernet, Modem and Bluetooth. Reason for choosing

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas created this revision. rthomas added a reviewer: jgrulich. rthomas added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. rthomas requested review of this revision. REVISION SUMMARY This bug has already been reported in bug 397352