D18578: Reduce string objects

2019-02-14 Thread Tomaz Canabrava
This revision was automatically updated to reflect the committed changes. Closed by commit R106:91b1f7115bf3: Reduce string objects (authored by tcanabrava). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18578?vs=50421&id=51653 REVISION DETAIL https://ph

D18578: Reduce string objects

2019-01-30 Thread Tomaz Canabrava
tcanabrava added a comment. In D18578#401842 , @apol wrote: > Looks okay from a theoretical point of view, I can expect the practical impact of this be about 0~ :P What I really like about math is that sum of changes with zero impact i

D18578: Reduce string objects

2019-01-29 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks okay from a theoretical point of view, I can expect the practical impact of this be about 0~ :P REPOSITORY R106 KSysguard BRANCH reduceStrings REVISION DETAIL https://phabricator.

D18578: Reduce string objects

2019-01-28 Thread Tomaz Canabrava
tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY QStringLiteral cannot deal with duplicates, so each invokation in the same file with the same string will create a different