D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland

2019-01-16 Thread Eike Hein
hein added inline comments. INLINE COMMENTS > davidedmundson wrote in virtualdesktopinfo.cpp:218 > Would it be safer to assume there's 1 row until we update. > > I'm sure we have some > > columns = count / rows > > code somewhere Indeed. I had 1 initially, but somehow it changed during editin

D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland

2019-01-16 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > virtualdesktopinfo.cpp:218 > QStringList virtualDesktops; > +uint cachedDesktopLayoutRows = 0; > KWayland::Client::PlasmaVirtualDesktopManagement > *virtualDesktopManagement = nullptr; Would it be safer to assume there's 1 ro

D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland

2019-01-16 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:49d9553f15c8: Use KWin's D-Bus interface to get desktop layout rows on Wayland (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18290?vs=

D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland

2019-01-16 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, davidedmundson, mart. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY While I think mixing IPC systems in this class is not the way to go long-term, we have a strong desire to ship a complete use