D17773: Copy to Clipboard in English

2019-01-18 Thread Nathaniel Graham
ngraham added a comment. Oops, wrong bug. Too many tabs open... Correcting the original comment now. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17773 To: guoyunhe, #plasma, ngraham Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Z

D17773: Copy to Clipboard in English

2019-01-18 Thread David Edmundson
davidedmundson added a comment. How can this affect discover? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17773 To: guoyunhe, #plasma, ngraham Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensre

D17773: Copy to Clipboard in English

2019-01-18 Thread Nathaniel Graham
ngraham added a comment. BTW I just discovered that this caused a regression: https://bugs.kde.org/show_bug.cgi?id=402104 It's currently publicly visible at https://blog.neon.kde.org/index.php/2019/01/17/test-kde-plasma-5-15-beta-with-neon/ :p REPOSITORY R102 KInfoCenter REVISION DE

D17773: Copy to Clipboard in English

2018-12-24 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R102:937e9c72fe94: Copy to Clipboard in English (authored by Guo Yunhe ). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17773?vs=48124&id=48154 R

D17773: Copy to Clipboard in English

2018-12-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better. This seems sensible to me. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D17773 To: guoyunhe, #plasma, ngraham Cc: ngraham, pl

D17773: Copy to Clipboard in English

2018-12-24 Thread Yunhe Guo
guoyunhe updated this revision to Diff 48124. guoyunhe edited the summary of this revision. guoyunhe added a comment. Hide the "Copy to Clipboard in English" button when the system is already in English. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D17773: Copy to Clipboard in English

2018-12-24 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Add a new button to copy to clipboard in English for usage in bug report. This doesn't affect existing copy button which copy tr