This revision was automatically updated to reflect the committed changes.
Closed by commit R838:9f0c704e96ea: Use KFileWidget instead of QFileDialog
(authored by jgrulich).
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1773
jgrulich added a comment.
Yes, it does work with your patch, thank you for that and sorry for my
laziness.
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
REVISION DETAIL
https://phabricator.kde.org/D17738
To: jgrulich, davidedmundson
Cc: plasma-devel, GB_2, ragreen, Pitel,
jgrulich updated this revision to Diff 48029.
jgrulich added a comment.
Use QScopedPointer for file dialogs
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17738?vs=48018&id=48029
BRANCH
master
REVISION DETAIL
https:
davidedmundson added a comment.
> https://phabricator.kde.org/D17677 will be still needed.
My rule about working round KDE code still applies.
Does this work: https://phabricator.kde.org/P285 on KIO for the remaining
case?
INLINE COMMENTS
> filechooser.cpp:289
> +QUrl url
jgrulich added a comment.
This still doesn't resolve bug 399889 so review
https://phabricator.kde.org/D17677 will be still needed.
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
REVISION DETAIL
https://phabricator.kde.org/D17738
To: jgrulich, davidedmundson
Cc: plasma-devel
jgrulich created this revision.
jgrulich added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.
REVISION SUMMARY
It would be used anyway, because QFileDialog in Plasma uses KFileWidget
through QPA
R
