D17685: Notify also if modes have changed

2018-12-19 Thread Andras Mantia
amantia closed this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17685: Notify also if modes have changed

2018-12-19 Thread Daniel Vrátil
dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. You can close the review for master and commit this to the stable branch, then merge stable to master. REPOSITORY R110 KScreen Library BRANCH Plasma/5.12 REVISION DETAIL https://p

D17685: Notify also if modes have changed

2018-12-19 Thread Andras Mantia
amantia added a comment. I have on for master and one for Plasma 5.12, as we want this in 5.12 as well, if approved. Should I keep only one of them? REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson, plasm

D17685: Notify also if modes have changed

2018-12-19 Thread David Edmundson
davidedmundson added a comment. You seem to have multiple reviews open for the same thing. Can you close the outdated ones please. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson, plasma-devel, GB_2, rag