This revision was automatically updated to reflect the committed changes.
Closed by commit R135:64002af69a86: Add support for settings portal (authored
by jgrulich).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17213?vs=4645
jgrulich added a comment.
@broulik, may I ask you for review?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D17213
To: jgrulich, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, a
jgrulich added inline comments.
INLINE COMMENTS
> jgrulich wrote in khintssettings.cpp:442
> Ok, I'll look into that.
It looks it's not that simple, this change would require other additions in
order to support KConfig overload. I would leave it as it is for now.
REPOSITORY
R135 Integration
jgrulich updated this revision to Diff 46457.
jgrulich marked 2 inline comments as done.
jgrulich added a comment.
Minor fixes
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17213?vs=46399&id=46457
BRANCH
jgrulich/portal
jgrulich marked 5 inline comments as done.
jgrulich added inline comments.
INLINE COMMENTS
> broulik wrote in khintssettings.cpp:66
> I thought Qt could de-serialize built-in types on its own?
Nope, I think it can't. You already told me this before, but from my experience
I always had to do it
broulik added a comment.
Good stuff!
INLINE COMMENTS
> kfontsettingsdata.cpp:81
>
> -const KConfigGroup configGroup(mKdeGlobals, fontData.ConfigGroupKey);
> -QString fontInfo = configGroup.readEntry(fontData.ConfigKey,
> QString());
> +QString fontInfo =
> readConf
jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.
REVISION SUMMARY
Sandboxed applications usually don't have access to read kdeglobals
configuration. For this
reason we introduced Settings porta
