D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

filipf added a comment. > [Ignore the flickering in the video; I'm not sure why that happens but it's an artifact of the software (SimpleScreenRecorder), not something that actually happens] Don't know anything about flickables, but maybe I can help with this. Screen recorders can flick

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham abandoned this revision. ngraham added a comment. Thanks so much, Marco! That does it and looks to be a more correct way to fix the problem. I've requested a backport for Kubuntu: T10130: Backport Kirigami scroll fix into Bionic Presumabl

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

mart added a comment. now scrollviews in qqc2 do that as well REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17143 To: ngraham, #plasma, #kirigami, mart Cc: fvogt, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

mart added a comment. check master now, done with a slightly different approach REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17143 To: ngraham, #plasma, #kirigami, mart Cc: fvogt, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. ah, i noticed now, shouldn't be done here, but rather in src/controls/templates/private/ScrollView.qml REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. In D17143#365563 , @fvogt wrote: > IMO this workaround is generic enough that adding it into `ScrollablePage.qml` or even `templates/private/Scrol

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham added a comment. In D17143#365585 , @fvogt wrote: > I agree, but I think it's more effective to fix this at the source in kirigami and ask distros to patch frameworks (which aren't LTS, so they're either updating versions or doing backpo

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

fvogt added a comment. > Yeah, I had a feeling that that might end up as a better place for the fix. Someone else would need to do that patch or help me with it though. I gave it a shot but couldn't get the binding right. It might be that in those cases Kirigami doesn't create the `Flick

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham added a comment. Yeah, I had a feeling that that might end up as a better place for the fix. Someone else would need to do that patch or help me with it though. I gave it a shot but couldn't get the binding right. Regardless, it might be nice to also land this on the stable branc

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

fvogt added a comment. IMO this workaround is generic enough that adding it into `ScrollablePage.qml` or even `templates/private/ScrollView.qml` itself is better as it hits almost every use. It would be nice to have a minimal reproducer to allow creating a QTBUG, but I haven't been succ

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham added a subscriber: mart. ngraham added a comment. @mart An alternative to this patch would be to fix https://bugs.kde.org/show_bug.cgi?id=401174 at the Kirigami level. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17143 To: ngraham, #plasma, #kiri

D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling

ngraham created this revision. ngraham added reviewers: Plasma, Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY By pixel-aligning the flickables, we eliminate text clipping artifacts caused by scrolli