This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:0d379c5957e2: [weather] Fix broken observation display
for temperature of 0 ° (authored by kossebau).
REPOSITORY
R11
kossebau updated this revision to Diff 45986.
kossebau added a comment.
diff against correct branch
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16977?vs=45985&id=45986
BRANCH
fix0DegreeTemperature
REVISION DETAIL
https://phabricator.kde.org/D
kossebau updated this revision to Diff 45985.
kossebau added a comment.
- use var data = weatherDataSource.currentData || {}; to simplify rest
- use typeof number !== "undefined"
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16977?vs=45724&id=45985
davidedmundson added a comment.
> Observation temperature of 0 ° no longer is shown as empty string,
Classic JS! well found.
It looks OK to me, but hopefully @broulik can have a look as quirky JS is
his specialty.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricat
kossebau created this revision.
kossebau added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.
REVISION SUMMARY
For that also deduplicate any data extraction & conversion logic
in helper methods fo
