D16860: touchscreen text controls

This revision was automatically updated to reflect the committed changes. Closed by commit R858:01411790d480: touchscreen text controls (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16860?vs=45408&id=46065 REVIS

D16860: touchscreen text controls

mart added a comment. for the future, could maybe be a global eventfilter of the window which does the switch of mode when a touch event arrived or when a mouse event arrived...will have to be tought trough... REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH phab/textcontrols

D16860: touchscreen text controls

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH phab/textcontrols REVISION DETAIL https://phabricator.kde.org/D16860 To: mart, #plasma, apol Cc: apol, broulik, plasma-dev

D16860: touchscreen text controls

mart added a comment. In D16860#364161 , @apol wrote: > isn't this a bit too binary? Maybe it makes sense to have hover effects even if on tablet mode. isn't it a matter of whether it comes from a finger? i don't think we can know that fr

D16860: touchscreen text controls

apol added a comment. isn't this a bit too binary? Maybe it makes sense to have hover effects even if on tablet mode. isn't it a matter of whether it comes from a finger? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16860 To: mart, #pla

D16860: touchscreen text controls

mart added inline comments. INLINE COMMENTS > broulik wrote in MobileTextActionsToolBar.qml:25 > Can you check whether this macro substitution actually works for the > "private" folder? yes it works correctly, the problem in the plasma version was the separate install of the style as an import

D16860: touchscreen text controls

broulik added inline comments. INLINE COMMENTS > MobileTextActionsToolBar.qml:25 > +import QtQuick.Window 2.2 > +import QtQuick.Controls @QQC2_VERSION@ > +import org.kde.kirigami 2.5 as Kirigami Can you check whether this macro substitution actually works for the "private" folder? REPOSITORY

D16860: touchscreen text controls

mart added a comment. F6420787: Screenshot_20181113_122130.png REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16860 To: mart, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D16860: touchscreen text controls

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY on QQC2 the controls to be able to select, cut,copy and paste text are responsibility of the style. thi