This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c4285ed1b407: Swap Trash/Delete when Shift is used while
the menu is open (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16368?vs=44091&i
hein updated this revision to Diff 44091.
hein added a comment.
Simplify patch.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16368?vs=44063&id=44091
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16368
AFFECTED FILES
containmen
ngraham added a comment.
Thanks Eike! Any chance this can go into the 5.12 branch?
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16368
To: hein, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesl
broulik added inline comments.
INLINE COMMENTS
> foldermodel.cpp:1854
> menu->popup(m_menuPosition);
> -connect(menu, &QMenu::aboutToHide, [menu]() { menu->deleteLater(); });
> +connect(menu, &QMenu::aboutToHide, [this, menu]() {
> +menu->deleteLater();
Use four argument con
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> foldermodel.cpp:653
> +// Trash and Delete actions while the Shift modifier is pressed.
> +// There's no point to doing so when the menu isn't op
hein created this revision.
hein added reviewers: ngraham, broulik.
Herald added a project: Plasma.
hein requested review of this revision.
REVISION SUMMARY
Matching Dolphin.
BUG:395155
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16368
