D16365: Update diff against newest master

2018-10-22 Thread Nathaniel Graham
ngraham added reviewers: jackg, Breeze. ngraham added a comment. Thanks, it looks good to me too in my testing. Any objections to landing this? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16365 To: ohelin, jackg, #breeze Cc: ngraham, plasma-devel, ragreen,

D16365: Update diff against newest master

2018-10-22 Thread Olli Helin
ohelin added a comment. I checked the both the diff_part files next to each other. All the other differences were quite easy to see, but this one bugs me a little: scrollbar.vertical button.down { -gtk-icon-source: -gtk-icontheme("pan-down-symbolic"); } scrollbar.vertical butt

D16365: Update diff against newest master

2018-10-21 Thread Nathaniel Graham
ngraham added a comment. JFYI, if we land this patch instead of the original, we'll credit the original author. But do feel free to continue along this vein and maybe do the same for the other GTK version CSS files in another patch afterwards if you'd like! REPOSITORY R98 Breeze for Gtk

D16365: Update diff against newest master

2018-10-21 Thread Nathaniel Graham
ngraham added a comment. Sort of an unorthodox way to do this, but... it works I guess! Thanks, the patch now applies, and rudimentary testing with some GTK apps doesn't show anything hideously wrong. I assume it works well enough for you too? REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D16365: Update diff against newest master

2018-10-21 Thread Olli Helin
ohelin added a comment. Ok, I just dissected the thing. First, I made the updated diff file against the newest master: **diff_updated.diff**. Then I saved these files from Phabricator: - **Breeze-dark-gtk_gtk-3.20_gtk.css**: saved the left raw diff file - **Breeze-gtk_gtk-3.20_common.

D16365: Update diff against newest master

2018-10-21 Thread Olli Helin
ohelin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ohelin requested review of this revision. REVISION SUMMARY Updated diff against newest master so that it applies again. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.k