D16014: Give ActionButton an optional and off-by-default drop shadow

ngraham added a comment. In D16014#338952 , @mart wrote: > Question: how are the icons done? See D15999: Add icons with added background to system.svgz > i think the circle should *not* be in the

D16014: Give ActionButton an optional and off-by-default drop shadow

mart added a comment. Question: how are the icons done? i think the circle should *not* be in the icon graphics, but in the qml part REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16014 To: ngraham, #plasma, #vdg Cc: mart, plasma-devel, ragreen, Pitel, Zr

D16014: Give ActionButton an optional and off-by-default drop shadow

ngraham abandoned this revision. ngraham added a comment. Collapsed changes into D16031 ; no need to have it separate here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16014 To: ngraham, #plasma, #vdg Cc: plasma-devel

D16014: Give ActionButton an optional and off-by-default drop shadow

ngraham updated this revision to Diff 43084. ngraham added a comment. Automatically use an appropriate color from the color scheme instead of hardcoding black and allowing it to be overridable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16014?v

D16014: Give ActionButton an optional and off-by-default drop shadow

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY `ActionButton`'s text can be difficult to see when the background is light-colored or very bu