D15749: Add tooltips to krunner configure and close buttons

acrouthamel added a comment. In D15749#331860 , @ngraham wrote: > would you like to do the honors and land this for him, @acrouthamel? Yes boss... Always roping me into something new. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D15749: Add tooltips to krunner configure and close buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f57460a61643: Add tooltips to krunner configure and close buttons (authored by slenz, committed by acrouthamel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.

D15749: Add tooltips to krunner configure and close buttons

ngraham added a comment. Since Silas lacks commit rights (I found this out by searching on https://websvn.kde.org/trunk/kde-common/accounts?view=markup), would you like to do the honors and land this for him, @acrouthamel? Make sure the git authorship is set properly first. Land on master pl

D15749: Add tooltips to krunner configure and close buttons

acrouthamel accepted this revision. acrouthamel added a comment. Ooh my first time being added as reviewer. ;) REPOSITORY R120 Plasma Workspace BRANCH krunner-tootlips (branched from master) REVISION DETAIL https://phabricator.kde.org/D15749 To: slenz, #vdg, acrouthamel, ngraham Cc: n

D15749: Add tooltips to krunner configure and close buttons

slenz updated this revision to Diff 42319. slenz added a comment. Remove "KRunner" from configure tooltip REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15749?vs=42318&id=42319 BRANCH krunner-tootlips (branched from master) REVISION DETAIL ht

D15749: Add tooltips to krunner configure and close buttons

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in RunCommand.qml:64 > Hmm, good question. Let me ask #VDG . For now, let's just go with "Configure..." and we'll sort out the user-facing string at another time so we don't derail your patch. :

D15749: Add tooltips to krunner configure and close buttons

ngraham added inline comments. INLINE COMMENTS > slenz wrote in RunCommand.qml:64 > You could argue KRunner is not used as a user-facing name anywhere (Setting > calls it `Plasma Search` and `Search Bar` depending on where you look). Might > be less confusing to just keep it at `Configure...`?

D15749: Add tooltips to krunner configure and close buttons

slenz added inline comments. INLINE COMMENTS > ngraham wrote in RunCommand.qml:64 > Needs ellipses; see > https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels > > How about "Configure KRunner..." ? You could argue KRunner is not used as a user-facing name anywhere (Setting c

D15749: Add tooltips to krunner configure and close buttons

slenz updated this revision to Diff 42318. slenz added a comment. Add ellipses and KRunner to configure tooltip. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15749?vs=42316&id=42318 BRANCH krunner-tootlips (branched from master) REVISION DETA

D15749: Add tooltips to krunner configure and close buttons

ngraham added a reviewer: acrouthamel. ngraham added a comment. Wow, that was fast. One minor suggestion: INLINE COMMENTS > RunCommand.qml:64 > visible: runnerWindow.canConfigure > +tooltip: i18nd("plasma_lookandfeel_org.kde.lookandfeel", > "Configure") > }

D15749: Add tooltips to krunner configure and close buttons

slenz created this revision. slenz added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. slenz requested review of this revision. REVISION SUMMARY Shows tooltips for buttons left and right of the search box. FEATURE: 398943 TEST PLAN Manually tes