D15683: Add lock icon to desktop context menu

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: abetts, safaalfulaij, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15683: Add lock icon to desktop context menu

ngraham added a comment. In D15683#329959 , @safaalfulaij wrote: > Why not also add icons to other items instead of other X number of commits coming later by Y number of people? > Yes, some don't have “group” icon (like sort, where only ascen

D15683: Add lock icon to desktop context menu

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: abetts, safaalfulaij, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15683: Add lock icon to desktop context menu

safaalfulaij added a comment. Why not also add icons to other items instead of other X number of commits coming later by Y number of people? Yes, some don't have “group” icon (like sort, where only ascending and descending are available), but I don't see a problem if we used any “child” one

D15683: Add lock icon to desktop context menu

anemeth added a comment. My arcanist is still borked. Could someone please push this? Thank you. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D15683: Add lock icon to desktop context menu

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliez