D15637: Make DBusMenu work correctly with dynamically generated menus

poboiko added a comment. In D15637#335295 , @broulik wrote: > From what I can tell this patch trades one bug (menu closing unexpectedly) for another one (menus erratically resizing/repositioning themselves). As for LyX it's not just menu

D15637: Make DBusMenu work correctly with dynamically generated menus

broulik added a comment. From what I can tell this patch trades one bug (menu closing unexpectedly) for another one (menus erratically resizing/repositioning themselves). I think we should be updating the actions in lockstep rather than adding all the things and then removing the old ones o

D15637: Make DBusMenu work correctly with dynamically generated menus

poboiko added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15637 To: poboiko, #plasma, broulik, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15637: Make DBusMenu work correctly with dynamically generated menus

poboiko added a comment. > Can this potentially throw off the order of items or cause items to be removed that got inserted previously (ID clash?)? As far as I can see, it should not be the case: those two operations should be totally interchangeable. Both "insert/update" and "remove"

D15637: Make DBusMenu work correctly with dynamically generated menus

broulik added a comment. I can see the menu sometimes flickering showing that it briefly has more actions than it used to be. Reproducible in Krita's "Window" menu when using title bar menu button and moving away form the menu. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://ph

D15637: Make DBusMenu work correctly with dynamically generated menus

broulik added a comment. Thanks for your patch! It also seems to fix some issues with menus unexpectedly closing in e.g. Kate or Thunderbird. Can this potentially throw off the order of items or cause items to be removed that got inserted previously (ID clash?)? Quick testing suggests

D15637: Make DBusMenu work correctly with dynamically generated menus

poboiko created this revision. poboiko added reviewers: Plasma, broulik. Herald added a project: Plasma. poboiko requested review of this revision. REVISION SUMMARY Right now, the "appmenutest" application fails to show the "Menu C" item, which is dynamically generated. (this also happens wit