This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:71833088fb26: Upgrade SimpleIpV4AddressValidator and
SimpleIpV6AddressValidator (authored by andersonbruce, committed b
jgrulich accepted this revision.
jgrulich added a comment.
Thanks for the contribution. I'll push this change and do just some minor
changes to the tests so you don't have to again go through review.
INLINE COMMENTS
> CMakeLists.txt:99
> add_subdirectory(vpn)
> +add_subdirectory(tests)
>
andersonbruce updated this revision to Diff 42297.
andersonbruce added a comment.
- Fix review comments
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15520?vs=42281&id=42297
BRANCH
IP4/6validatorsUpdate
REVISION DETAIL
https:
andersonbruce updated this revision to Diff 42281.
andersonbruce added a comment.
- Fix a case that was being reported as Acceptable rather than Intermediate
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15520?vs=41878&id=42281
BR
andersonbruce updated this revision to Diff 41878.
andersonbruce added a comment.
- Remove unnecessary includes and member functions
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15520?vs=41875&id=41878
BRANCH
IP4/6validatorsUpd
pino added a comment.
- please remove all the empty `initTestCase()` in tests
INLINE COMMENTS
> simpleiplistvalidator.cpp:27-28
> +SimpleIpListValidator::SimpleIpListValidator(QObject *parent,
> + AddressStyle style,
> +
andersonbruce updated this revision to Diff 41875.
andersonbruce added a comment.
- Merge new IP list validator into this branch
- Update from review comments
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15520?vs=41677&id=41875
pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.
- same notes for `simpleipv6test.cpp` as in `simpleipv4test.cpp`
INLINE COMMENTS
> CMakeLists.txt:11-13
> +add_executable(simpleipv6test ${simpleipv6test_SRCS})
> +add_test(simpleipv6
ngraham added a comment.
Thanks! And since I don't believe this patch on its own is sufficient to
resolve 397572, please change `FEATURE: 397572` to `CCBUG: 397572`. The former
will close the bug once this lands; the latter just adds the commit info as a
comment, but keeps the bug open--whic
