D15495: Add Messages.sh

2018-09-14 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:715ba3a22906: Add Messages.sh (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15495?vs=41650&id=41651 REVISION DETAIL htt

D15495: Add Messages.sh

2018-09-14 Thread Alexander Potashev
aspotashev accepted this revision. aspotashev added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15495 To: broulik, #plasma, davidedmundson, #localization, aacid, aspotashev Cc: as

D15495: Add Messages.sh

2018-09-14 Thread Kai Uwe Broulik
broulik updated this revision to Diff 41650. broulik added a comment. - Move `Messages.sh` into `reminder` dir REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15495?vs=41620&id=41650 REVISION DETAIL https://phabricator.kde.org/D15495 A

D15495: Add Messages.sh

2018-09-14 Thread Alexander Potashev
aspotashev added a comment. We already have tabsrunner/Messages.sh so adding this Messages.sh will extract the messages from tabsrunner/* twice. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15495 To: broulik, #plasma, davidedmundson, #localizat

D15495: Add Messages.sh

2018-09-14 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. Alright, will move it to the reminder then REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15495 To: broulik, #plasma, davidedmundson, #localization, aacid Cc: aspotashev, ltoscano,

D15495: Add Messages.sh

2018-09-14 Thread Kai Uwe Broulik
broulik updated this revision to Diff 41620. broulik added a comment. Fix typo.. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15495?vs=41619&id=41620 REVISION DETAIL https://phabricator.kde.org/D15495 AFFECTED FILES CMakeLists.txt

D15495: Add Messages.sh

2018-09-14 Thread Luigi Toscano
ltoscano added a comment. Correct: the names should be different, and so the domains. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15495 To: broulik, #plasma, davidedmundson, #localization, aacid Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenB

D15495: Add Messages.sh

2018-09-14 Thread Kai Uwe Broulik
broulik updated this revision to Diff 41619. broulik added a comment. Rename to `plasma-browser-integration-native` I could have moved it to the host but I fear we will forget again should we ever use `i18n` in the host (which I did at one point) REPOSITORY R856 Plasma Browser Integration

D15495: Add Messages.sh

2018-09-14 Thread David Edmundson
davidedmundson added a comment. According to https://websvn.kde.org/trunk/l10n-kf5/scripts/ update_translations it seems both Messages.sh and StaticMessages.sh will be invoked. But I don't think we can use the same .pot name. REPOSITORY R856 Plasma Browser Integration REVISION DET

D15495: Add Messages.sh

2018-09-14 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, Localization, aacid. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We have translatable strings in the reminder c++ code. TEST P