This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0ac6c595389c: [Bookmarks Runner] Expose list of tables
from FetchSqlite (authored by bruns).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15488?vs=41588&
bruns updated this revision to Diff 41588.
bruns added a comment.
scrap spurious line
lock mutex
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15488?vs=41582&id=41588
REVISION DETAIL
https://phabricator.kde.org/D15488
AFFECTED FILES
runner
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fetchsqlite.cpp:104
> +
> +QStringList FetchSqlite::tables(QSql::TableType type)
> +{
please guard this with the mutex
> fetchsqlite.cpp:106
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.
REVISION SUMMARY
This is a preparatory patch required for further rework
TEST PLAN
make
REPOSITORY
R120 Plasma
