D15423: System settings: make date/time format preview consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d4671edc8198: System settings: make date/time format preview consistent (authored by McPain, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15423?vs=41398&id=56302#toc R

D15423: System settings: make date/time format preview consistent

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein, #vdg Cc: GB_2, davidedmundson, abetts, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmformats.cpp:322 > I don't understand, why is this sometimes empty? Sorry for delayed reply. In KCMFormats::initCombo we add locales to combo boxes. First we add a QString() for "No change" option and then we add all poss

D15423: System settings: make date/time format preview consistent

davidedmundson added inline comments. INLINE COMMENTS > kcmformats.cpp:322 > +str = m_ui->comboNumbers->currentData().toString(); > +nloc = str.isEmpty() ? QLocale(glob) : QLocale(str); > + I don't understand, why is this sometimes empty? REPOSITORY R119 Plasma Desktop REVISI

D15423: System settings: make date/time format preview consistent

ngraham accepted this revision as: VDG. ngraham added a comment. Looks good to me, and doesn't regress anything in any of the other locales I tried. I'll let @hein do a final review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein, #vdg

D15423: System settings: make date/time format preview consistent

ngraham added a reviewer: VDG. ngraham added a comment. Thanks, that helps! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas

D15423: System settings: make date/time format preview consistent

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

McPain added a comment. Before: F6252186: изображение.png After: F6252262: изображение.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: ngraham, plasm

D15423: System settings: make date/time format preview consistent

ngraham added a comment. Before-and-after screenshots can make a big difference in the reviewability of a patch like this. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai

D15423: System settings: make date/time format preview consistent

McPain created this revision. McPain added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 398493 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 AF