D15331: [Folder View] Hide /home/foo/Desktop place in configuration

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R119:45c420b7fd11: [Folder View] Hide /home/foo/Desktop place in configuration (authored by broulik). REPOSITORY R119

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

hein added a comment. Let's not bother with it then, thanks for looking into it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15331 To: broulik, #plasma, hein, fvogt Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

broulik added a comment. I just `setDynamicSortFilter(false);` in the constructor and `setDynamicSortFilter(true);` in `QQmlParserStatus::componentComplete()` but it doesn't make a difference. The `filterAcceptsRow()` method is called the same number of times upon opening the config dialog

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

broulik planned changes to this revision. broulik added a comment. Alright, will look into `QQmlParserStatus`, didn't know about `dynamicSortFilter` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15331 To: broulik, #plasma, hein, fvogt Cc: davidedmundson, ng

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

davidedmundson added a comment. > It's just a QSortFilterProxyModel so not sure we can "delay" the filtering? setDynamicSortFilter on/off REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15331 To: broulik, #plasma, hein, fvogt Cc: davidedmundson, ngraham,

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

broulik added a comment. It's just a `QSortFilterProxyModel` so not sure we can "delay" the filtering? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15331 To: broulik, #plasma, hein, fvogt Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

hein added a comment. Is it worth adding QQmlParserStatus to PlacesModel at this point? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15331 To: broulik, #plasma, hein, fvogt Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensre

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

ngraham added a comment. > There is no "Desktop" entry in places by default but I have seen many users add it Actually I added that in D11768 . :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15331 To: broulik, #pla

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

broulik created this revision. broulik added reviewers: Plasma, hein, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Folder View is meant to use `desktop:/` and having two entries that behave differentl