D15143: Allow creation of separator Actions

This revision was automatically updated to reflect the committed changes. Closed by commit R169:91ea75c37045: Allow creation of separator Actions (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15143?vs=42465&id=42655 REVISION DETAI

D15143: Allow creation of separator Actions

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. In D15143#333127 , @dkardarakos wrote: > Previously introduced "separator mode" removed from AbstractListItem and BasicListItem. > > Instead

D15143: Allow creation of separator Actions

dkardarakos updated this revision to Diff 42465. dkardarakos added a comment. Previously introduced "separator mode" removed from AbstractListItem and BasicListItem. Instead of a solution totally inside globaldrawer and contextdrawer I opted for a new BasicListItem alias property (reserv

D15143: Allow creation of separator Actions

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. i don't think it's necessary to put separatordelegate in the public api, it can be something local in globaldrawer and contextdrawer directly, without adding new properties that will

D15143: Allow creation of separator Actions

dkardarakos updated this revision to Diff 40647. dkardarakos edited the summary of this revision. dkardarakos added a comment. Function isSeparator removed REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15143?vs=40639&id=40647 REVISION DETAIL https://ph

D15143: Allow creation of separator Actions

broulik added a comment. `isSeparator()` is for use in C++, that method is neither a slot nor `Q_INVOKABLE` so you cannot use it from QML anyway. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15143 To: dkardarakos, mart Cc: broulik, plasma-devel, apol, davidedmun

D15143: Allow creation of separator Actions

dkardarakos added a comment. isSeparator function has been added to ensure compatibility with QAction https://doc.qt.io/qt-5/qaction.html#isSeparator. We do not need it? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15143 To: dkardarakos, mart Cc: broulik, plasma

D15143: Allow creation of separator Actions

broulik added inline comments. INLINE COMMENTS > Action.qml:172 > + */ > +function isSeparator() { > +return separator; That function is superfluous, you have the property after all > ActionsMenu.qml:55 > if (!action.children || action.children.length === 0) { >

D15143: Allow creation of separator Actions

dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY The QAction class allows an action to be considered a separator. In Kirigami Action t