D15086: Fix localization of QML code

2018-08-27 Thread Yuri Chornoivan
This revision was automatically updated to reflect the committed changes. Closed by commit R846:164602da8171: Fix localization of QML code (authored by yurchor). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15086?vs=40460&id=40531#toc REPOSITORY R846 Mycroft Plasma integration CHANG

D15086: Fix localization of QML code

2018-08-26 Thread Yuri Chornoivan
yurchor updated this revision to Diff 40460. yurchor added a comment. Adding more context to the messages REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15086?vs=40458&id=40460 REVISION DETAIL https://phabricator.kde.org/D15086 AFFECT

D15086: Fix localization of QML code

2018-08-26 Thread Burkhard Lück
lueck added a comment. probably the strings with "%1 : %2" need context for propr tarnslation INLINE COMMENTS > CurrentWeatherType.qml:191 > Component.onCompleted: { > -weatherMinLabel.text = "Minimum Temperature: " + slttemp > +weather

D15086: Fix localization of QML code

2018-08-26 Thread Yuri Chornoivan
yurchor updated this revision to Diff 40458. yurchor added a comment. Getting rid of French punctuation REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15086?vs=40450&id=40458 REVISION DETAIL https://phabricator.kde.org/D15086 AFFECTED

D15086: Fix localization of QML code

2018-08-26 Thread Karl Ove Hufthammer
huftis added a comment. You could take the opportunity to change the ‘French’ punctuation in the three `"%1 : %2"` strings to proper English punctuation, i.e. `"%1: %2"`. REPOSITORY R846 Mycroft Plasma integration REVISION DETAIL https://phabricator.kde.org/D15086 To: yurchor, Aiix, #lo

D15086: Fix localization of QML code

2018-08-26 Thread Yuri Chornoivan
yurchor created this revision. yurchor added reviewers: Aiix, Localization. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY The current code contains untranslatable messages and word puzzles [1]. This patch tri