D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgrulich, sitter, jriddell Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

broulik added a comment. In D14835#317622 , @jgrulich wrote: > Another thing is, can Plasma 5.14 depend on KDE Frameworks 5.50? Yes. According to [1] the dependency is 5.50 [1] https://community.kde.org/Schedules/Plasma_5 REPOSITORY

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

jgrulich added a comment. Another thing is, can Plasma 5.14 depend on KDE Frameworks 5.50? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgrulich, sitter, jriddell Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBo

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

sitter added a comment. Thanks for asking. This is fine with us, the ubuntu 16.04 base is going away in due time. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgrulich, sitter, jriddell Cc: broulik, plasma-devel

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

jgrulich added a comment. Can we get some opinions from KDE Neon people? I have older review to bump NM requirements to 1.4.0 here https://phabricator.kde.org/D12493. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma,

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov updated this revision to Diff 40632. volkov added a comment. minimize the number of setDeviceStatisticsRefreshRateMs() callings REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14835?vs=39790&id=40632 BRANCH master REVISION

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov added a comment. Unfortunately KDE Neon is based on Ubuntu 16.04 (Xenial) which is using NM 1.2: https://packages.ubuntu.com/source/xenial/network-manager REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgru

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

jgrulich added a comment. I assume we can bump requirements to NM 1.4, even Debian stable is now using NM 1.6. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgrulich Cc: broulik, plasma-devel, ragreen, Pitel, Zre

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. Hmm, taking it back, actually this cannot be used as it requires NM 1.4 and newer and we require NM 1.0 and newer. REPOSITORY R116 Plasma Network Management Applet REVISION

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good to me. I was thinking about using it already some time ago, but didn't really find time to change that so thank you for implementing it. Actually, I think it was not possible

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov updated this revision to Diff 39790. volkov added a comment. update device statistics only when it's shown REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14835?vs=39698&id=39790 BRANCH master REVISION DETAIL https://pha

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov added inline comments. INLINE COMMENTS > broulik wrote in networkmodel.cpp:220 > Would it be better to only request the data when the statistics are open to > avoid wakeups and processing? Yes, good point. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://pha

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

broulik added inline comments. INLINE COMMENTS > networkmodel.cpp:220 > +auto deviceStatistics = device->deviceStatistics(); > +deviceStatistics->setRefreshRateMs(2000); > +connect(deviceStatistics.data(), > &NetworkManager::DeviceStatistics::rxBytesChanged, this, [this, > device](q

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY It's more correct to get information about devices from a single source, i.e. from NetworkManager. Besides it allows to show the t