D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2020-06-13 Thread Carl Schwan
ognarb added a comment. I rebased this merge request on top of master and moved it to gitlab. https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/37 I see a major problem to move forward with this patch, not all the files have a license header and as such can't be merged. @gpar

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2019-10-15 Thread Vladimir Yerilov
yerilov added a comment. Thanks @apol I've built it from your branch and testing it now. Here is a list of issues I have faced so far: 1. Layout switch doesn't work on Lock screen. Visually layouts are shown as switched, but actually it's always English. 2. I have 3 layouts: EurKey,

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2019-10-15 Thread Aleix Pol Gonzalez
apol added a comment. So I decided to rebase the patch onto current master. I pushed it rebased into a branch called `apol/D14796` because I didn't know whether to take over this review. I would appreciate it if someone could help me tell why it wasn't merged. I see: > It needs a l

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2019-10-12 Thread Eike Hein
hein added a comment. Ping @gpark, are you available to resume work on this too? There's a growing amount of interest which means more dev hands to aid the effort. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: davideichelsdoerfer,

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2019-09-24 Thread Vladimir Yerilov
yerilov added a comment. This fails to build now. > The longer we wait, the harder it will be to integrate So true. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: davideichelsdoerfer, yerilov, kucharczyk, lavender, ngraham,

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2019-01-23 Thread Nathaniel Graham
ngraham added a comment. Fantastic news! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: kucharczyk, lavender, ngraham, apol, plasma-devel, hein, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2019-01-23 Thread Eike Hein
hein added a comment. @gpark just came back from an exchange semester. We met the other day and will schedule a work session in Feb to resume on this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: kucharczyk, lavender, ngraham, apo

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2019-01-21 Thread Nathaniel Graham
ngraham added a comment. I tried to test this out, but it doesn't apply to master anymore. Applying and then rebasing on master results in a ton of merge conflicts. :( Is there any movement on this? It would be a real shame to let such a huge amount of valuable work rot away. Even just r

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2018-10-24 Thread Peridot Lavender
lavender added a comment. This redesign seems like a good place to start thinking about integrating accessibility options T with the rest of the settings. I included some screenshots of what OSX does (Switch Control

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2018-10-23 Thread Nathaniel Graham
ngraham added a comment. If this patch can, practically speaking, be applied and used, I'm happy to offer some UI review, and I suspect other #VDG folks would, too. If not, screenshots would be helpful. :) REPOSITORY R119 Plasma Desktop REVISION DET

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2018-10-22 Thread Eike Hein
hein added a comment. In D14796#347289 , @apol wrote: > What's the status of this? The longer we wait, the harder it will be to integrate. We just branched 5.14, maybe it's time to consider doing so? It needs a lot of review, VDG feedback

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2018-10-22 Thread Aleix Pol Gonzalez
apol added a comment. What's the status of this? The longer we wait, the harder it will be to integrate. We just branched 5.14, maybe it's time to consider doing so? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: apol, plasma-devel,

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2018-08-13 Thread Gun Park
gpark created this revision. gpark added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gpark requested review of this revision. REVISION SUMMARY finish Hardware section stash unset CMAKE_INSTALL_PREFIX fi