This revision was automatically updated to reflect the committed changes.
Closed by commit R112:816a923f7c05: Support both QString and QIcon for
dragHelper pixmap (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14545?vs=39285&id=39303#toc
REPOSITORY
R112 Milou
CH
broulik updated this revision to Diff 39285.
broulik added a comment.
Turns out the library is really exported and the qml plugin just links to it
rather than "be" that library.
- Add another overload instead
REPOSITORY
R112 Milou
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Meh, then go for it.
Remove the unneeded exports? (In a separate patch, if you want)
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D14545
To: broulik, #plasma, apol
C
broulik added inline comments.
INLINE COMMENTS
> apol wrote in draghelper.h:46
> This is an exported method, is this not a public library? :/
Milou is released as part of plasma and this class is only for QML use, don't
recall why it's exported anymore but there's also no header installed for i
apol added inline comments.
INLINE COMMENTS
> draghelper.h:46
> Q_INVOKABLE bool isDrag(int oldX, int oldY, int newX, int newY)
> const;
> -Q_INVOKABLE void startDrag(QQuickItem* item, QMimeData *mimeData,
> const QIcon &icon = QIcon());
> +Q_INVOKABLE void startDrag(QQ
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
The model was changed a while ago to return a QString if possible
