This revision was automatically updated to reflect the committed changes.
Closed by commit R104:a6929de88b89: QMLScreen: do not declare the engine a
member (authored by gladhorn).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14476?vs=38857&id=38860#toc
REPOSITORY
R104 KScreen
CHANGE
gladhorn updated this revision to Diff 38857.
gladhorn added a comment.
Remove more cruft
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14476?vs=38745&id=38857
BRANCH
arcpatch-D14476
REVISION DETAIL
https://phabricator.kde.org/D14476
AFFECTED FILES
gladhorn added inline comments.
INLINE COMMENTS
> broulik wrote in qmlscreen.h:109
> This entire custom engine handling could be removed, with `QMLScreen` using
> `qmlEngine(this)` when creating an `QMLOutput`
I had briefly tried and got a nullptr from qmlEngine, but I didn't really spend
time
broulik added inline comments.
INLINE COMMENTS
> qmlscreen.h:109
>
> QQmlEngine* m_engine = nullptr;
> QMLOutput *m_leftmost = nullptr;
This entire custom engine handling could be removed, with `QMLScreen` using
`qmlEngine(this)` when creating an `QMLOutput`
REPOSITORY
R104 KScre
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Note, that m_engine is set in widget.cpp. But it's just a Cpp call to
setEngine, which is defined extra. So removing the property macro should be
fine.
REPOSITORY
R104 KScreen
REVISIO
gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gladhorn requested review of this revision.
REVISION SUMMARY
There is no need for this, the only use of the engine is when c
