aacid added a comment.
@davidedmundson No he doesn't.
He also doesn't have an actual name, so i didn't commit the patch myself.
REPOSITORY
R106 KSysguard
BRANCH
arcpatch-D1
REVISION DETAIL
https://phabricator.kde.org/D1
To: al1xz, apol
Cc: aacid, davidedmundson, zzag, pla
davidedmundson added a comment.
Do you have commit accecss?
REPOSITORY
R106 KSysguard
BRANCH
arcpatch-D1
REVISION DETAIL
https://phabricator.kde.org/D1
To: al1xz, apol
Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, ab
al1xz updated this revision to Diff 38762.
al1xz marked an inline comment as done.
al1xz added a comment.
Update
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1?vs=38674&id=38762
BRANCH
arcpatch-D1
REVISION DETAIL
https://phabricator.kde.or
al1xz updated this revision to Diff 38674.
al1xz added a comment.
Update
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1?vs=38665&id=38674
BRANCH
arcpatch-D1
REVISION DETAIL
https://phabricator.kde.org/D1
AFFECTED FILES
gui/SensorBro
zzag added inline comments.
INLINE COMMENTS
> ListViewSettings.cpp:47
>delete m_settingsWidget;
> + m_settingsWidget = nullptr;
> }
This class is about to go away so this assignment is redundant.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D1
To: al1xz
al1xz created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
al1xz requested review of this revision.
REPOSITORY
R106 KSysguard
BRANCH
new (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D1
AFF
