piotrkakol added a comment.
Yes, but I forgeted to put them in the last diff. Do I really have to make a
separate diff to change it?
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D14384
To: piotrkakol, davidedmundson
Cc: zzag, gladhorn, ngraham, davidedmundso
zzag added a comment.
w.r.t. this patch, those 2 copyright changes look really unrelated.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D14384
To: piotrkakol, davidedmundson
Cc: zzag, gladhorn, ngraham, davidedmundson, plasma-devel, ragreen, Pitel,
ZrenBot, l
piotrkakol added a comment.
I did change main.qml as you can see here:
https://phabricator.kde.org/R114:9eae090a3038ebf97ffeee8c9b773a8610e13021
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D14384
To: piotrkakol, davidedmundson
Cc: gladhorn, ngraham, davide
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
this is putting big assumptions about the UI in the code and doesn't make
things better.
INLINE COMMENTS
> main.qml:3
> * Copyright 2014 Joseph Wenninger
> + *
piotrkakol added a comment.
Ping.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D14384
To: piotrkakol
Cc: gladhorn, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
piotrkakol created this revision.
Restricted Application added a project: Plasma.
piotrkakol requested review of this revision.
REPOSITORY
R114 Plasma Addons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14384
AFFECTED FILES
applets/binary-clock/package/contents/config/conf
