gladhorn updated this revision to Diff 38516.
gladhorn added a comment.
Initialize m_changeCompressor to nullptr
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14359?vs=38400&id=38516
BRANCH
arcpatch-D14359
REVISION DETAIL
https://phabricator.kde.org/
romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.
What @broulik says. It should be fine with the `m_changeCompressor` being
startet in `init`, but the git message should note this. Also the git message
could be a bit more descr
broulik added inline comments.
INLINE COMMENTS
> daemon.h:79
> +bool m_monitoring = false;
> QTimer* m_changeCompressor;
> +QTimer* m_saveTimer = nullptr;
This is now uninitialized initially
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14359
gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gladhorn requested review of this revision.
REVISION SUMMARY
Making the other timers lazy-initialized is more tricky, so for
