D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-26 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14347 To: ngraham, #plasma, davidedmundson, broulik Cc: abetts, broulik, svenmauch, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-26 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1467427b6569: Fix blocky text on splash screen when using non-integer scale factor (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14

D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-26 Thread Nathaniel Graham
ngraham added a comment. In D14347#298510 , @broulik wrote: > > Add the right import (this somehow works without it, so there must be an implicit import somewhere...) > > More like it fails to `assign [undefined] to int` and then it never cha

D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-26 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. Anyway, ship it REPOSITORY R120 Plasma Workspace BRANCH fix-blocky-splash-screen-text (branched from Plasma/5.12) REVISION DETAIL https://phabricator.kde.org/D14347 To: ngraham, #plasma, davidedmundson, broulik Cc:

D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-26 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. > Add the right import (this somehow works without it, so there must be an implicit import somewhere...) More like it fails to `assign [undefined] to int` and then it never changes t

D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 38419. ngraham added a comment. Add the right import (this wqsomehow works without it, so there must be an implicit import somewhere...) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14347?vs=38366&id=38419

D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-24 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > Splash.qml:91 > +// https://bugreports.qt.io/browse/QTBUG-67007 > +renderType: Screen.devicePixelRatio % 1 !== 0 ? > Text.QtRendering : Text.NativeRendering > anchors.verticalCenter: parent.vertical

D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-24 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Qt bug that makes `Text.NativeRendering` look t