D14326: Fix layout of resolution selection

This revision was automatically updated to reflect the committed changes. Closed by commit R104:5b6e9767a73e: Fix layout of resolution selection (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14326?vs=38515&id=38543 REVISION DETAIL h

D14326: Fix layout of resolution selection

gladhorn updated this revision to Diff 38515. gladhorn added a comment. Fix the layout REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14326?vs=38317&id=38515 BRANCH arcpatch-D14326_1 REVISION DETAIL https://phabricator.kde.org/D14326 AFFECTED FILES

D14326: Fix layout of resolution selection

gladhorn added a comment. The alignment previous to this commit is also not given, it just happens to look a hint better. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg, ngraham Cc: andreaska, abetts, ngraham, broulik, zzag, plasma

D14326: Fix layout of resolution selection

ngraham added a comment. Thanks, that should have been obvious! :p I get the same layout issue as Kai with the slider though. With the slider, the label on the left should be top-aligned. and line up with the slider's line. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator

D14326: Fix layout of resolution selection

gladhorn added a comment. In D14326#297253 , @ngraham wrote: > I agree. +1 on how it looks with a combobox. Is there any way to manually remove resolutions so I can get it to use a slider and test that case? Just change the if condition (

D14326: Fix layout of resolution selection

ngraham added a comment. I agree. +1 on how it looks with a combobox. Is there any way to manually remove resolutions so I can get it to use a slider and test that case? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: andreaska,

D14326: Fix layout of resolution selection

gladhorn added a comment. In the meantime, I'd like opinions on this change, I'm still a big fan of small steps in the right direction which will reach users soon, since I'm unsure if the big re-design will be implemented in the near future. REPOSITORY R104 KScreen REVISION DETAIL https

D14326: Fix layout of resolution selection

gladhorn added a comment. @abetts see D14339 for the icons. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: andreaska, abetts, ngraham, broulik, zzag, plasma-devel, ragreen, Pitel, ZrenBot, l

D14326: Fix layout of resolution selection

ngraham added a comment. Let's centralize the discussion in T7254 . I've closed the other two. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: andreaska, abetts, ngraham, broulik, zzag, plasma-

D14326: Fix layout of resolution selection

gladhorn added a comment. OK, so shall we discuss the general KCM in https://phabricator.kde.org/T7254 or https://phabricator.kde.org/T4066 or https://phabricator.kde.org/T3464 ? all of them seem to be duplicates, but I don't know how to handle that. REPOSITORY R104 KScreen REVISION DETAI

D14326: Fix layout of resolution selection

andreaska added a comment. The thing is that you should bring more focus to the screen factor setting. Ordinary you should not change the screen resolution you should change the factor on hidpi this should be in focus. Nobody should change the resolution and the rate by default cause best r

D14326: Fix layout of resolution selection

abetts added a comment. In D14326#297020 , @gladhorn wrote: > In D14326#297016 , @abetts wrote: > > > In D14326#296853 , @gladhorn wrote: > > > > > F613

D14326: Fix layout of resolution selection

gladhorn added a comment. In D14326#297016 , @abetts wrote: > In D14326#296853 , @gladhorn wrote: > > > F6134401: kcm_res_bef.png F6134403: kcm_res_aft.png

D14326: Fix layout of resolution selection

abetts added a comment. In D14326#296853 , @gladhorn wrote: > F6134401: kcm_res_bef.png F6134403: kcm_res_aft.png F6134417: kcm_resolution_before.png

D14326: Fix layout of resolution selection

abetts added a comment. +1 on the visual changes! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: abetts, ngraham, broulik, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14326: Fix layout of resolution selection

ngraham added a comment. In D14326#296957 , @gladhorn wrote: > In D14326#296857 , @broulik wrote: > > > The slider case after looks misaligned here now. I think you should set margins to zero only f

D14326: Fix layout of resolution selection

gladhorn added a comment. In D14326#296857 , @broulik wrote: > The slider case after looks misaligned here now. I think you should set margins to zero only for the ComboBox case where there is only that single widget? > F613: Screenshot_2

D14326: Fix layout of resolution selection

broulik added a comment. > How does it look with the slider? There's screenshots. This patch is solely about the margins, not the fact that it uses a slider or combobox > Off-topic: Is the slider a good idea from UX/UI perspective? That is why it uses a `QComboBox` if there are

D14326: Fix layout of resolution selection

broulik added a comment. The slider case after looks misaligned here now. I think you should set margins to zero only for the ComboBox case where there is only that single widget? F613: Screenshot_20180724_122521.png REPOSITORY R104 KScreen RE

D14326: Fix layout of resolution selection

zzag added a comment. How does it look with the slider? Off-topic: Is the slider a good idea from UX/UI perspective? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, al

D14326: Fix layout of resolution selection

gladhorn added a comment. F6134401: kcm_res_bef.png F6134403: kcm_res_aft.png F6134405: kcm_resfresh_before.png F6134408: kcm_refresh_after.png

D14326: Fix layout of resolution selection

gladhorn created this revision. gladhorn added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The resolution slider or combo added extra spacing, which i