D14325: Remove Advanced section from screen config

abetts added a comment. +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14325: Remove Advanced section from screen config

This revision was automatically updated to reflect the committed changes. Closed by commit R104:51c93ef1f9eb: Remove Advanced section from screen config (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14325?vs=38315&id=38338 REVISION DE

D14325: Remove Advanced section from screen config

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Don't explicitly mess with the combobox sizes; just use a `QFormLayout` and let it handle that for you. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.k

D14325: Remove Advanced section from screen config

gladhorn added a comment. @ngraham https://phabricator.kde.org/D14326 fixes the alignement of the combo box, it's unrelated to using a form layout. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma, #vdg, ngraham Cc: ngrah

D14325: Remove Advanced section from screen config

gladhorn added a comment. I can play with the drop-down sizes in a follow up change. To keep reviews as easy as possible, I prefer to make minimal changes with less chance of breakage :) I'm unsure about how wide the combo boxes should be though, taking the full width would make them look

D14325: Remove Advanced section from screen config

ngraham added a comment. Approved; having a single item under an Advanced section didn't make much sense. Also, in the next patch we can use a nice simple `QFormLayout` for everything here, which is good because the misalignment of the Resolution ComboBox is driving me bananas! :) REPOSITOR

D14325: Remove Advanced section from screen config

andreaska added a comment. Will be useful. Can you make the dropdown items all the same size. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma, #vdg Cc: andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterb

D14325: Remove Advanced section from screen config

gladhorn added a comment. F6134344: kcm_resfresh_before.png F6134347: kcm_refresh_after.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma Cc: plasma-devel, ra

D14325: Remove Advanced section from screen config

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY There was only one option hidden behind the andvanced section,