D14234: [Folder View] Improve file name text rendering

2018-07-20 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5fca2b32ce5b: [Folder View] Improve file name text rendering (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14234?vs=38097&id=38125#toc REPOSITORY R119 Plasma Desktop

D14234: [Folder View] Improve file name text rendering

2018-07-20 Thread Eike Hein
hein added a comment. It kind of sucks we have to do this, we have a lot of different UIs we'd have to copy-paste this fix too, but after a few minutes of mulling I didn't come up with a better idea :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14234 To

D14234: [Folder View] Improve file name text rendering

2018-07-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks better with fractional scaling and doesn't regress at all for 1x scaling. Drop shadows are still rendered. Code looks good. REPOSITORY R119 Plasma Desktop REVISION DETAIL https

D14234: [Folder View] Improve file name text rendering

2018-07-19 Thread Chris Holland
Zren added a comment. I tested the `x: -main.x % 1` code. Before: F6120560: 2018-07-19___13-46-20.png After: F6120562: 2018-07-19___13-47-29.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https

D14234: [Folder View] Improve file name text rendering

2018-07-19 Thread Kai Uwe Broulik
broulik updated this revision to Diff 38097. broulik added a comment. - Don't even bother creating the `DropShadow` if not supported REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14234?vs=38096&id=38097 REVISION DETAIL https://phabricator.kde.org

D14234: [Folder View] Improve file name text rendering

2018-07-19 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein, davidedmundson, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `GridView` pads out its delegate to