D14227: Use AbstractDBusRunner instead of custom export + plugin

2018-07-19 Thread David Edmundson
davidedmundson updated this revision to Diff 38074. davidedmundson added a comment. Rebase. Hopefully arc will show something correct now REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14227?vs=38070&id=38074 BRANCH runner_without_mute

D14227: Use AbstractDBusRunner instead of custom export + plugin

2018-07-19 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > tabsrunnerplugin.h:38-39 > public: > explicit TabsRunnerPlugin(QObject *parent); > +TabsRunnerPlugin(QObject *parent); > +~TabsRunnerPlugin(); Does it compile? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://pha

D14227: Use AbstractDBusRunner instead of custom export + plugin

2018-07-19 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Contains everything as before in half the cod