This revision was automatically updated to reflect the committed changes.
Closed by commit R104:97f7b9cff782: Remove ref from returned QString (authored
by gladhorn).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14152?vs=37922&id=37983
REVISION DETAIL
htt
gladhorn updated this revision to Diff 37922.
gladhorn added a comment.
Re-added the const
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14152?vs=37851&id=37922
BRANCH
arcpatch-D14152
REVISION DETAIL
https://phabricator.kde.org/D14152
AFFECTED FILES
zzag added inline comments.
INLINE COMMENTS
> osd.cpp:58
>
> -const QString &osdPath =
> QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation,
> QStringLiteral("kded_kscreen/qml/Osd.qml"));
> +QString osdPath =
> QStandardPaths::locate(QStandardPaths::QStandardP
gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gladhorn requested review of this revision.
REVISION SUMMARY
Let's leave it up to the compiler to eliminate the ref.
Sugge
