This revision was automatically updated to reflect the committed changes.
Closed by commit R104:ce68ee44e099: Move KCM to UI file (authored by gladhorn).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14024?vs=37501&id=37594#toc
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https
zzag added inline comments.
INLINE COMMENTS
> widget.h:46-48
> +namespace Ui {
> +class KScreenWidget;
> +}
Coding style nitpick:
namespace Ui
{
class KScreenWidget;
}
> widget.h:96
>private:
> +Ui::KScreenWidget *ui;
> QMLScreen *mScreen = nullptr;
Naming nitpick: mU
ngraham added a comment.
OK, no problem. :)
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14024
To: gladhorn, #plasma, sebas
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
gladhorn added a comment.
Sure, but let's get there step by step. In general this needs some
un-tangling of functionality and UI first.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14024
To: gladhorn, #plasma, sebas
Cc: ngraham, plasma-devel, ragreen, Pitel, Zren
ngraham added a comment.
If we're going to do any UI porting, how about to QML instead? That's the
future.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14024
To: gladhorn, #plasma, sebas
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
gladhorn updated this revision to Diff 37501.
gladhorn added a comment.
Fixed stretch for unified outputs
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14024?vs=37496&id=37501
BRANCH
gladhorn/ui
REVISION DETAIL
https://phabricator.kde.org/D14024
AFF
gladhorn added a comment.
depends on https://phabricator.kde.org/D14023
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14024
To: gladhorn, #plasma, sebas
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
gladhorn created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gladhorn requested review of this revision.
REVISION SUMMARY
This fixes the size policy, the only element we want expanding is the
preview area on top, every
