D13870: Correct Folder View sizing and representation switch behavior

2019-01-17 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > main.qml:58 > + > +return undefined; > +} This and the same below sadly results in error log output e.g. when testing applets with plasmoidviewer: file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/main.qml

D13870: Correct Folder View sizing and representation switch behavior

2018-07-04 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4ad27c62b5e7: Correct Folder View sizing and representation switch behavior (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13870?vs=37115

D13870: Correct Folder View sizing and representation switch behavior

2018-07-03 Thread Michail Vourlakos
mvourlakos added a comment. In D13870#286578 , @hein wrote: > Add back useful comment. I tested the patch and I couldnt reproduce the tiny popup window with plasma, I checked also the Latte parabolic effect and it was working. +1, G

D13870: Correct Folder View sizing and representation switch behavior

2018-07-03 Thread Eike Hein
hein updated this revision to Diff 37115. hein added a comment. Add back useful comment. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13870?vs=37114&id=37115 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13870 AFFECTED FILES c

D13870: Correct Folder View sizing and representation switch behavior

2018-07-03 Thread Eike Hein
hein updated this revision to Diff 37114. hein added a comment. - Add the missing switch stuff. - Remove stray debug. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13870?vs=37113&id=37114 BRANCH master REVISION DETAIL https://phabricator.kde

D13870: Correct Folder View sizing and representation switch behavior

2018-07-03 Thread Eike Hein
hein planned changes to this revision. hein added a comment. Whoops, I accidentally uploaded the wrong diff, hang on. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13870 To: hein, mart, broulik, mvourlakos Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezha

D13870: Correct Folder View sizing and representation switch behavior

2018-07-03 Thread Eike Hein
hein created this revision. hein added reviewers: mart, broulik, mvourlakos. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY - Resolve inherent layout hint conflicts between full and compact representations by setting them seperately. Thi