D13853: Fix setting primary connector if primary output changed

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13853 To: hoffmannrobert, #plasma, mart, davidedmundson Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D13853: Fix setting primary connector if primary output changed

ngraham added a comment. Done! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D13853 To: hoffmannrobert, #plasma, mart, davidedmundson Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe

D13853: Fix setting primary connector if primary output changed

hoffmannrobert added a comment. Thanks for reviewing. Can you please land it for me, I don't have commit access. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D13853 To: hoffmannrobert, #plasma, mart, davidedmundson Cc: davidedmundson, ngr

D13853: Fix setting primary connector if primary output changed

hoffmannrobert updated this revision to Diff 37174. hoffmannrobert added a comment. - Remove wrong Q_ASSERT REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13853?vs=37072&id=37174 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1385

D13853: Fix setting primary connector if primary output changed

hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. Addition to last comment: In the other case, booting with HDMI-2 and hotplugging HDMI-3 the problem with primary switching doesn't exist. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.

D13853: Fix setting primary connector if primary output changed

hoffmannrobert marked an inline comment as done. hoffmannrobert added inline comments. INLINE COMMENTS > davidedmundson wrote in screenpool.cpp:108 > Either this is a valid case to be in, and this assert doesn't make sense. > > Or we should never be in this case, and the patch doesn't make sense

D13853: Fix setting primary connector if primary output changed

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > screenpool.cpp:108 > } > Q_ASSERT(m_idForConnector.contains(primary)); > Either this is a valid case to be in, and this assert doe

D13853: Fix setting primary connector if primary output changed

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY If a user logged in with one screen connected plugs in a second screen, which become