D13679: Fix recent toolbar layout regression

mart added a comment. In D13679#283361 , @ngraham wrote: > Aleix implemented a better version of this with https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233 I'm still not sure about it. is it supposed

D13679: Fix recent toolbar layout regression

ngraham abandoned this revision. ngraham added a comment. Aleix implemented a better version of this with https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13679 To:

D13679: Fix recent toolbar layout regression

mart added a comment. last version of D13663 should fix that bug REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13679 To: ngraham, #discover_software_store Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D13679: Fix recent toolbar layout regression

mart added a comment. oh, yes, i know why the extra space problem, i'll fix INLINE COMMENTS > mart wrote in DiscoverWindow.qml:30 > why the logic of all of this? no applicationheader should be there at any point, in any formfactor, unless you want something to go on top of the toolbar REPO

D13679: Fix recent toolbar layout regression

mart added inline comments. INLINE COMMENTS > DiscoverWindow.qml:30 > > ConditionalObject { > id: whichToolbar why the logic of all of this? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13679 To: ngraham, #discover_software_store Cc:

D13679: Fix recent toolbar layout regression

ngraham created this revision. ngraham added a reviewer: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY D13663 fixed