D13602: Fix tooltip woes

2018-06-22 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:1e218b405bee: Fix tooltip woes (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13602?vs=36405&id=36537 REVISION DETAIL https://phabricat

D13602: Fix tooltip woes

2018-06-22 Thread Rik Mills
rikmills added a comment. I have tested the modified patch on the same environment with Qt 5.10.1 where I found the crash with the previous version in 5.13.0 tars. plasmashell now seems to start without issue on login REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricato

D13602: Fix tooltip woes

2018-06-20 Thread Eike Hein
hein updated this revision to Diff 36405. hein added a comment. Fix crash on Qt <5.11 This makes no sense, but fixes the crash reliably in testing. Since it works on 5.11, this may be a bug that got fixed in Qt. I didn't bisect it though. REPOSITORY R119 Plasma Desktop CHANGES SINC

D13602: Fix tooltip woes

2018-06-19 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:24803dc9dc40: Fix tooltip woes (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13602?vs=36319&id=36321#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D13602: Fix tooltip woes

2018-06-19 Thread Eike Hein
hein added a comment. In D13602#279963 , @davidedmundson wrote: > > race condition > > a race between what? To be honest, I didn't fully figure it out. But when the assignment in Tasks.qml was an integer to the delegate, it meant tha

D13602: Fix tooltip woes

2018-06-19 Thread David Edmundson
davidedmundson added a comment. > race condition a race between what? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13602 To: hein, broulik, davidedmundson, romangg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abe

D13602: Fix tooltip woes

2018-06-19 Thread Eike Hein
hein created this revision. hein added reviewers: broulik, davidedmundson, romangg. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Users have reported a number of bugs against TM tooltips, e.g. initially coming up with crazy sizes, or s