D13360: Touchpad KDED module: Convert to JSON metadata

dfaure added a comment. I didn't fully follow this saga, but AFAICS this patch was reverted (commit 3432c3342b1f801 , bug 395622), so we still rely on desktop files to load the touchpad kded module. Can this patch be

D13360: Touchpad KDED module: Convert to JSON metadata

kossebau added a comment. In D13360#280205 , @marten wrote: > Apologies for the unforeseen trouble. Happens also to the best now and then, and only to get better the next time :) > I'll revert the committed change for now, and then in

D13360: Touchpad KDED module: Convert to JSON metadata

cfeck added a comment. Regression has been reported as bug 395622. Please close when fixed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13360 To: marten, #plasma, davidedmundson Cc: cfeck, kossebau, fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, l

D13360: Touchpad KDED module: Convert to JSON metadata

marten added a comment. Apologies for the unforeseen trouble. I'll revert the committed change for now, and then investigate the fix that @kossebau suggests in the previous comment. If this doesn't work then I'll look into splitting the kded and kcm modules into separate ones with a common

D13360: Touchpad KDED module: Convert to JSON metadata

kossebau added a comment. Given the D-Bus object path for the module is generated from the moduleid, which is set by kded using the KPluginMetaData::pluginId (in `KDEDModule *Kded::loadModule(const KPluginMetaData &module, bool onDemand)`, a fix might have been instead to set in the kded_tou

D13360: Touchpad KDED module: Convert to JSON metadata

kossebau added a comment. This patch seems to have broken things ("kcm does not load") by what people reported in irc for 5.13.1. By a quick investigation the main reason is, that the old plugin binary with the name "kded_touchpad" is used both to provide the plugin for kcm as well as t

D13360: Touchpad KDED module: Convert to JSON metadata

fvogt added a comment. This doesn't seem to be in Plasma/5.13. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13360 To: marten, #plasma, davidedmundson Cc: fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts

D13360: Touchpad KDED module: Convert to JSON metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d0307eff98f2: Touchpad KDED module: Convert to JSON metadata (authored by marten). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13360?vs=35608&id=36264#toc REPOSITORY R119 Plasma Desktop

D13360: Touchpad KDED module: Convert to JSON metadata

davidedmundson added a comment. I guess so. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13360 To: marten, #plasma, davidedmundson Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13360: Touchpad KDED module: Convert to JSON metadata

romangg added a comment. Should the patch be backported to 5.13 since it's a fix for the daemon according to the description? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13360 To: marten, #plasma, davidedmundson Cc: romangg, plasma-devel, ragreen, Pitel,

D13360: Touchpad KDED module: Convert to JSON metadata

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. marten requested review of this revision. REVISION SUMMARY This is now the preferred way of providing plugin metadata. It's not