D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. Message received and understood. Sorry for jumping the gun. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13122 To: sharvey, ngraham, hein, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D13122: Add second line of text for KickerDash item descriptions

hein added a comment. I'm fine with this, but yes, in the future it's a good idea to wait for maintainer review, or e.g. one VDG and one "code monkey" review - we do a bad job communicating who "needs" to approve though so it's not really on you, and I'm OK with erring on the side of work pr

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. Oh. I see. The Phab emails say "now ready to land", so I did what the machine told me to. But I clearly see your point. Hopefully he will be okay with it. If not, I'm more than willing to roll it back and make any further changes. REPOSITORY R119 Plasma Deskto

D13122: Add second line of text for KickerDash item descriptions

ngraham added a comment. Hmm, I might have waited for @hein's review too... One thing I'm myself just now coming to understand is that it's often a good idea to wait for more than just one reviewer to offer their view. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.k

D13122: Add second line of text for KickerDash item descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cd7252e9fa07: Add second line of text for KickerDash item descriptions (authored by sharvey). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13122?vs=34895&i

D13122: Add second line of text for KickerDash item descriptions

sharvey updated this revision to Diff 34895. sharvey added a comment. - - Remove trailing whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13122?vs=34885&id=34895 BRANCH two-row-dash (branched from master) REVISION DETAIL https://phabr

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. I forgot it was a bug. I thought it was an assignment. :-) REPOSITORY R119 Plasma Desktop BRANCH two-row-dash (branched from master) REVISION DETAIL https://phabricator.kde.org/D13122 To: sharvey, ngraham, hein, plasma-devel Cc: ragreen, Pitel, ZrenBot, leslie

D13122: Add second line of text for KickerDash item descriptions

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, this is exactly how I'd have done it, too. Since this fixes https://bugs.kde.org/show_bug.cgi?id=362986, let's add `BUG: 362986` at the bottom of the Summary (if you do it with t

D13122: Add second line of text for KickerDash item descriptions

sharvey added a comment. F5868921: Screenshot_20180525_164110.png Unfortunate line breaks in long file names. See line 98. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13122 To: sharvey, ngraham, hein, plasma-devel

D13122: Add second line of text for KickerDash item descriptions

sharvey added inline comments. INLINE COMMENTS > ItemGridDelegate.qml:98 > elide: Text.ElideRight > -wrapMode: Text.NoWrap > +wrapMode: Text.Wrap > Note: will wrap at an arbitrary point if there's no natural break. Happens with long filenames under "Recent Documents"

D13122: Add second line of text for KickerDash item descriptions

sharvey created this revision. sharvey added reviewers: ngraham, hein, plasma-devel. Restricted Application added a project: Plasma. sharvey requested review of this revision. REVISION SUMMARY Adds a second line of text under icon/doc icons for more clarity. Will stop at two lines; if text con