D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:033ad5ca60b3: Port Plasma Desktop Scripting to QJSEngine (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13112?vs=35838&id=35839 REVISI

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread Marco Martin
mart updated this revision to Diff 35838. mart added a comment. - newError function to create JS errors REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13112?vs=34864&id=35838 BRANCH mart/QJSEngineScripting REVISION DETAIL https://phabricator.

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread David Edmundson
davidedmundson added a comment. Oh sorry, I meant to find one. Yep that's the script I meant. Awesome. Ship it! REPOSITORY R120 Plasma Workspace BRANCH mart/QJSEngineScripting REVISION DETAIL https://phabricator.kde.org/D13112 To: mart, #plasma, davidedmundson Cc: davidedmundson,

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread Marco Martin
mart added a comment. https://github.com/pashazz/ksetwallpaper/blob/master/ksetwallpaper.py works perfectly REPOSITORY R120 Plasma Workspace BRANCH mart/QJSEngineScripting REVISION DETAIL https://phabricator.kde.org/D13112 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-08 Thread Marco Martin
mart added a comment. In D13112#275382 , @davidedmundson wrote: > + > Thanks for tackling a very boring and difficult task. > > There are two things I'd like to see also tested: > > - the DBus wallpaper changing script that I know

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-06-07 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. + Thanks for tackling a very boring and difficult task. There are two things I'd like to see also tested: - the DBus wallpaper changing script that I know a bu

D13112: Port Plasma Desktop Scripting to QJSEngine

2018-05-25 Thread Marco Martin
mart updated this revision to Diff 34864. mart added a comment. proper diff REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13112?vs=34863&id=34864 BRANCH mart/QJSEngineScripting REVISION DETAIL https://phabricator.kde.org/D13112 AFFECTED FIL