D13073: Weigh matching services by relating data used in query to their menuids

This revision was automatically updated to reflect the committed changes. Closed by commit R120:664b90afcfd8: Weigh matching services by relating data used in query to their menuids (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13

D13073: Weigh matching services by relating data used in query to their menuids

hein updated this revision to Diff 34804. hein added a comment. Don't both mutate _and_ return. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13073?vs=34742&id=34804 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13073 AFFE

D13073: Weigh matching services by relating data used in query to their menuids

hein updated this revision to Diff 34742. hein marked 3 inline comments as done. hein added a comment. - Consistently use isEmpty(). - Make intro to comment less ambiguous. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13073?vs=34741&id=34742 B

D13073: Weigh matching services by relating data used in query to their menuids

hein marked 3 inline comments as done. hein added inline comments. INLINE COMMENTS > broulik wrote in tasktools.cpp:374 > `isEmpty` (unless consistent with the rest but it seems to be mixed already) Will change. > broulik wrote in tasktools.cpp:228 > This comment makes it sound like this preten

D13073: Weigh matching services by relating data used in query to their menuids

broulik added a comment. Fine in principle, surely adds less complexity than my weird rewriting stuff that also just attempted to fix Chrome :D INLINE COMMENTS > tasktools.cpp:374 > // The appId looks like a path. > -if (appId.startsWith(QStringLiteral("/"))) { > +

D13073: Weigh matching services by relating data used in query to their menuids

hein updated this revision to Diff 34741. hein added a comment. Remove forgotten QDebug include. Thanks to @cfeck, who I now know is just as anal about include collation as I am. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13073?vs=34740&

D13073: Weigh matching services by relating data used in query to their menuids

cfeck added inline comments. INLINE COMMENTS > tasktools.cpp:45 > #include > +#include > #include Can be removed? If not, sort correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13073 To: hein, broulik, davidedmundson Cc: cfeck, plasma-devel, rag

D13073: Weigh matching services by relating data used in query to their menuids

hein updated this revision to Diff 34740. hein added a comment. Optimize common case. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13073?vs=34739&id=34740 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13073 AFFECTED FILES

D13073: Weigh matching services by relating data used in query to their menuids

hein added a comment. I'll add that KServiceTypeTrader doesn't offer any facilities for weighing. KService has a `KService::initialPreference()` but that seems only useful when sorting services for a MIME type by prioirty (and I'd guess it's maybe also used for KCM sorting?) and isn't applic

D13073: Weigh matching services by relating data used in query to their menuids

hein created this revision. hein added reviewers: broulik, davidedmundson. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY The overall mission of TaskTools::windowUrlFromMetadata is to use various pieces of metadata to run KServiceTypeTr