This revision was automatically updated to reflect the committed changes.
Closed by commit R120:30654e2158c4: Remove legacy Wine hack-around from rules
rc. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13058?vs=34702&id=34729
REV
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
kcmshell5 still shows proper icon and some Wine apps I tested also work fine,
however wine notepad is just as broken as before
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.12
RE
hein added a comment.
I was a bit worried my latest change could break the case of kcmshell setting
KCM .desktop files (which are NoDisplay), but on X11, this is done via a window
hint we evaluate directly in XWindowsTasksModel (bypassing TaskTools) and in
any case it's set to a path, which
hein updated this revision to Diff 34702.
hein added a comment.
It turns out Wine installs its Windows Program Loader as a wine.desktop
file, which is useful to "Open With" .exe files, but means if Wine doesn't
set a WM_CLASS that we can find a .desktop file by StartupWMClass for, we
map
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
[12:26] Sho_: what happens with this patch and an old wine?
[12:28] d_ed: the result should be the same. because ManualOnly is a
vestige from old libtm, but the new li
hein created this revision.
hein added reviewers: broulik, davidedmundson.
Restricted Application added a project: Plasma.
hein requested review of this revision.
REVISION SUMMARY
After we improved our StartupWMClass handling we worked with Wine
in https://bugs.winehq.org/show_bug.cgi?id=32699
