D12960: Drag handle to reorder items in a ListView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:c6f88c7d504d: Drag handle to reorder items in a ListView (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE

D12960: Drag handle to reorder items in a ListView

mart updated this revision to Diff 35107. mart added a comment. - proper version - use handle icon REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12960?vs=34430&id=35107 BRANCH mart/dragHandle REVISION DETAIL https://phabricator.kde.org/D12960 AFF

D12960: Drag handle to reorder items in a ListView

mart added a comment. In D12960#265012 , @alex-l wrote: > I tried with arrows too, but I think the fifth one looks better... my second choice is the third one. > > F5858203: immagine.png i like t

D12960: Drag handle to reorder items in a ListView

alex-l added a comment. Possible interactions on hover (I used the third one and the fourth one when dragging): F5858223: immagine.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein

D12960: Drag handle to reorder items in a ListView

alex-l added a comment. I tried with arrows too, but I think the fifth one looks better... my second choice is the third one. F5858203: immagine.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigam

D12960: Drag handle to reorder items in a ListView

alex-l added a comment. Cursors and hover: F5856535: immagine.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmund

D12960: Drag handle to reorder items in a ListView

mart added a comment. In D12960#264749 , @ngraham wrote: > IMHO the up-and-down arrows do a much better job of communicating "drag me!" than a 9 dot grid does. good point, so so far my favourite are the options by alex REPOSITORY R169

D12960: Drag handle to reorder items in a ListView

ngraham added a comment. IMHO the up-and-down arrows do a much better job of communicating "drag me!" than a 9 dot grid does. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-deve

D12960: Drag handle to reorder items in a ListView

mart added a comment. In D12960#264737 , @alex-l wrote: > In D12960#264732 , @alex-l wrote: > > > F5856484: immagine.png > > > I think the mouse cursor sho

D12960: Drag handle to reorder items in a ListView

alex-l added a comment. In D12960#264732 , @alex-l wrote: > F5856484: immagine.png I think the mouse cursor should be: - drag-open-hand for first one - clickable-finger (like for links) for sec

D12960: Drag handle to reorder items in a ListView

abetts added a comment. In D12960#264734 , @ngraham wrote: > Regardless of what icon we choose, for a drag handle, I think it has to be a very light gray. We previously had a 4x3 dot grid, but because it was black, it looked very heavy and when

D12960: Drag handle to reorder items in a ListView

ngraham added a comment. In D12960#264732 , @alex-l wrote: > F5856484: immagine.png I really like the vertical drag icon here! Not so sure about the horizontal swipe icon though. REPOSITORY R169 K

D12960: Drag handle to reorder items in a ListView

ngraham added a comment. Regardless of what icon we choose, for a drag handle, I think it has to be a very light gray. We previously had a 4x3 dot grid, but because it was black, it looked very heavy and when a bunch of them were all lined up vertically, the net effect was sort of weird.

D12960: Drag handle to reorder items in a ListView

alex-l added a comment. F5856484: immagine.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

abetts added a comment. In D12960#264657 , @rkflx wrote: > F5855884: drag-handles.png I think with this image we are trying to convey too much. Users in general, will understand that if you have a co

D12960: Drag handle to reorder items in a ListView

rkflx added a comment. F5855884: drag-handles.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

ngraham added a comment. How about the version like that, but with fewer dots? I thought those looked really, really good. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: ngraham, zzag, plasma-devel, apol, davidedmundson, m

D12960: Drag handle to reorder items in a ListView

mart added a comment. Possible handles (to resume that old discussion) F5855838: Spectacle.q10653.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: zzag, plasma-devel, apol, davided

D12960: Drag handle to reorder items in a ListView

mart updated this revision to Diff 34430. mart added a comment. all files REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12960?vs=34426&id=34430 BRANCH mart/dragHandle REVISION DETAIL https://phabricator.kde.org/D12960 AFFECTED FILES examples/gall

D12960: Drag handle to reorder items in a ListView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:5ba11c3b9efe: proper version (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12960?vs=34425&

D12960: Drag handle to reorder items in a ListView

mart updated this revision to Diff 34425. mart added a comment. - proper version REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12960?vs=34423&id=34425 BRANCH mart/dragHandle REVISION DETAIL https://phabricator.kde.org/D12960 AFFECTED FILES exampl

D12960: Drag handle to reorder items in a ListView

zzag added inline comments. INLINE COMMENTS > kirigamiplugin.cpp:172 > +//2.5 > +qmlRegisterType(componentUrl(QStringLiteral("ListItemDragHandle.qml")), > uri, 2, 4, "ListItemDragHandle"); > + Is the minor version correct? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricat

D12960: Drag handle to reorder items in a ListView

mart added a comment. in action https://youtu.be/vQUnOpwV9xU note that the red square icon is a placeholder, new breeze icons are needed for that REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: plasma-devel, apol, da

D12960: Drag handle to reorder items in a ListView

mart created this revision. mart added reviewers: Kirigami, VDG, hein. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY A component to be inserted in list items of any kind, when us