D12926: Set variable for chromium install dir

2018-05-16 Thread Jonathan Riddell
This revision was automatically updated to reflect the committed changes. Closed by commit R856:fa06ad6b7090: Set variable for chromium install dir (authored by jriddell). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12926?vs=34286&id=3429

D12926: Set variable for chromium install dir

2018-05-16 Thread Jonathan Riddell
jriddell updated this revision to Diff 34286. jriddell added a comment. - add back comment about ubuntu REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12926?vs=34281&id=34286 BRANCH master REVISION DETAIL https://phabricator.kde.org

D12926: Set variable for chromium install dir

2018-05-16 Thread Bhushan Shah
bshah accepted this revision. bshah added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:75 > # chromium > -# in ubuntu and derivatives, this should be installed in the > chromium-browser/extensions, > -# but since this is distribu

D12926: Set variable for chromium install dir

2018-05-16 Thread Jonathan Riddell
jriddell created this revision. jriddell added a reviewer: bshah. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jriddell requested review of this revision. REVISION SUMMARY Set variable for chromium install dir TEST PLAN make; install