This revision was automatically updated to reflect the committed changes.
Closed by commit R120:38367efd5e93: Fix Logout screen countdown not cancelling
on multi-monitor setups (authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
davidedmundson updated this revision to Diff 34195.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.
Address all comments
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12893?vs=34186&id=34195
BRANCH
master
REVIS
zzag added a comment.
@broulik: `for ... in` iterates over the enumerable properties. This would
lead to "weird unexpected"(not really) results. ECMAScript 2015 introduced `for
... of` statement that iterates over data. In most cases, `for ... of` should
be preferred over `for ... in`, unles
broulik added a comment.
This is both genius and evil. I like that you kept it all in the theme.
INLINE COMMENTS
> timer.js:25
>
> -import "../components"
> +var callbacks = new Array();
>
`var callbacks = [];`
> timer.js:27
>
> -ActionButton {
> -property var action
> -onClic
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
The logout greeter theme has a timer that inv
