D12870: [SourcesModel] Check changed file name before reloading configuration

2018-05-14 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R112:c0fa968c08fc: [SourcesModel] Check changed file name before reloading configuration (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12870?vs=341

D12870: [SourcesModel] Check changed file name before reloading configuration

2018-05-14 Thread Kai Uwe Broulik
broulik added a comment. `KDirWatch` is a singleton and when this is used from within plasmashell (e.g. Kickoff's search model) it will cause changes as `Units` adds watchers on plasma configs REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D12870 To: broulik, #plasma

D12870: [SourcesModel] Check changed file name before reloading configuration

2018-05-14 Thread Aleix Pol Gonzalez
apol added a comment. It doesn't look like other files are being added to the KDirWatch, no? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D12870 To: broulik, #plasma Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D12870: [SourcesModel] Check changed file name before reloading configuration

2018-05-14 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoid needlessly reloading configuration if something completely u